Conversation
|
Tests are failing with: It's to do with depreciation in the seabird package, which is only used for testing the added noise in test_ctd_make_realistic.py. However, the added noise procedure is currently not implemented in VirtualShip. Can we remove this test for the time being? And re-add it should we add the noise back in down the line? Commenting it out is a temporary option... cc @ammedd |
|
Yes, please do comment out the seabird package for now. We'll add it later indeed. It requires a bit of thinking/discussing on our side. |
j-atkins
requested review from
VeckoTheGecko,
ammedd and
erikvansebille
and removed request for
VeckoTheGecko
| # def test_ctd_make_realistic(tmpdir) -> None: | ||
| # # add noise and convert to cnv | ||
| # files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_") |
There was a problem hiding this comment.
I would either add a TODO comment with reference to the GitHub Issue if we expect the package to be back online later; or completely remove (instead of comment out) seabird when we don't expect it to be useable anytime in the future
| # def test_ctd_make_realistic(tmpdir) -> None: | |
| # # add noise and convert to cnv | |
| # files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_") | |
| # TODO readable this test when seabird package works again (see #200) | |
| # def test_ctd_make_realistic(tmpdir) -> None: | |
| # # add noise and convert to cnv | |
| # files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_") |
There was a problem hiding this comment.
Good idea. Seabird doesn't not appear very active so I have removed it, and added a TODO for future reference.
3 participants
Updated copernicusmarine dependency to v2.2.2, which fixes the bug raised in #198.
virtualship fetchis now working again!